fix(connectors): support default credential provider chain for iceberg sink#3045
Open
gomnitrix wants to merge 7 commits intoapache:masterfrom
Open
fix(connectors): support default credential provider chain for iceberg sink#3045gomnitrix wants to merge 7 commits intoapache:masterfrom
gomnitrix wants to merge 7 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3045 +/- ##
============================================
+ Coverage 70.52% 70.54% +0.01%
Complexity 943 943
============================================
Files 1115 1115
Lines 95388 95445 +57
Branches 72589 72646 +57
============================================
+ Hits 67275 67330 +55
+ Misses 25634 25633 -1
- Partials 2479 2482 +3
🚀 New features to boost your workflow:
|
1ae3328 to
b324786
Compare
Contributor
|
@EdgarModesto23 would you mind checking this? |
Contributor
|
@hubcio sure! |
hubcio
requested changes
Apr 7, 2026
core/integration/tests/connectors/fixtures/iceberg/container.rs
Outdated
Show resolved
Hide resolved
core/integration/tests/connectors/iceberg/default_credentials_config/config.toml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2911
Rationale
Production environments prefer the default credential provider chain over static keys, which the Iceberg Sink connector currently lacks support for.
What changed?
The Iceberg Sink connector previously failed to initialize if
store_access_key_idandstore_secret_access_keywere missing from the config, blocking the use of standard identity-based auth. This fix makes these config fields optional, allowing the underlying OpenDAL seamlessly fall back to the default credential provider chain. An isolated integration test was also added to verify this fallback behavior using environment variables.Local Execution
E2E Validation Results
The fallback mechanism has been verified through:
1. Automated Integration Test
Added a new test fixture:
IcebergEnvAuthFixtureand a corresponding integration test case:iceberg_sink_uses_default_credential_chain. It simulates the environment by omitting config credentials, injectingAWS_environment variables, and validating whether the test data successfully flushes to MinIO using the fallback chain.2. Manual Local Verification
I also successfully verified this end-to-end. Providing credentials exclusively via the environment triggered the fallback correctly and successfully routed Iggy messages to the catalog:
Click to view the local verification logs
AI Usage
iceberg_sink_uses_default_credential_chainintegration test.